OpenChat

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

OpenChat AI

Weekly Rules Review: 2026-03-09

## Weekly Rules Documentation Review - 2026-03-09 ### Overall Health Assessment The rules documentation is in **good shape overall**. All 11 rule files are relevant, and the vast majority of file paths and code patterns they reference still exist in the codebase. Two files need minor updates, and one has a moderate accuracy issue. --- ### Audit Results #### AGENTS.md **Status**: Keep **Reasoning**: Core agent guide is accurate and well-structured. The rules index table, project setup instructions, pre-commit checks, and general guidance are all current. References to `npm run ts`, `tsgo`, TanStack Router, and Base UI are correct. --- #### rules/electron-ipc.md **Status**: Keep **Reasoning**: High-value, comprehensive guide. All referenced file paths exist (`src/ipc/contracts/core.ts`, `src/ipc/types/*.ts`, `src/ipc/handlers/base.ts`, `src/lib/queryKeys.ts`). The `pendingStreamChatIds` pattern still exists in `useStreamChat.ts`. The `writeSettings` shallow merge warning is still relevant (confirmed by recent fix in commit ef4ec84 preventing stale settings reads). --- #### rules/local-agent-tools.md **Status**: Keep **Reasoning**: Concise and accurate. `modifiesState` flag is actively used across many tool files. `buildAgentToolSet` exists in `tool_definitions.ts`. `handleLocalAgentStream` exists in `local_agent_handler.ts` with `readOnly`/`planModeOnly` guards confirmed. `todo_persistence.ts` exists. `fs.promises` guidance remains relevant for Electron main process. --- #### rules/e2e-testing.md **Status**: Needs Update **Reasoning**: Mostly accurate and high-value, but has two inaccuracies in helper method references. **Issues Found**: - Lines 64-75: References `po.clearChatInput()` and `po.openChatHistoryMenu()` as methods on PageObject directly, but they actually live on the `chatActions` sub-component: `po.chatActions.clearChatInput()` and `po.chatActions.openChatHistoryMenu()`. This contradicts the sub-component pattern documented earlier in the same file (lines 29-43). **Suggested Changes**: - Update the Lexical editor section examples to use `po.chatActions.clearChatInput()` and `po.chatActions.openChatHistoryMenu()` instead of `po.clearChatInput()` and `po.openChatHistoryMenu()` --- #### rules/git-workflow.md **Status**: Keep **Reasoning**: Comprehensive and high-value. Contains many hard-won learnings about fork workflows, `gh pr create` edge cases, GitHub API workarounds, and rebase conflict resolution patterns. The `GITHUB_TOKEN` workflow chaining limitation and the `--input` pattern for special characters are particularly valuable. Recent commits (51fc07e - GitHub App tokens) confirm this area is actively evolving. **Note**: This is the longest rules file (123 lines). Some of the very specific rebase conflict tips (React component wrapper conflicts, refactoring conflicts) may be overly situational, but they're low-cost to keep. --- #### rules/base-ui-components.md **Status**: Keep **Reasoning**: All referenced component files exist (`context-menu.tsx`, `tooltip.tsx`, `accordion.tsx`). `@base-ui/react` is in the project dependencies. The TooltipTrigger `render` prop guidance and Accordion API differences from Radix are high-value patterns that prevent common mistakes. --- #### rules/database-drizzle.md **Status**: Keep **Reasoning**: Short and high-value. `drizzle/meta/_journal.json` exists. Migration conflict resolution guidance is important for rebase workflows. --- #### rules/typescript-strict-mode.md **Status**: Keep **Reasoning**: All references verified. `tsconfig.app.json` confirms ES2020 target with `lib: ["ES2020"]`. The `tsgo` installation note (Go binary, not npm package) and `response.json()` returning `unknown` are valuable gotchas. Node.js >= 24 requirement is noted. --- #### rules/openai-reasoning-models.md **Status**: Needs Update **Reasoning**: The core concept is still valid - orphaned reasoning parts are still filtered in `src/ipc/utils/ai_messages_utils.ts`. However, the specific function name referenced is outdated. **Issues Found**: - References `filterOrphanedReasoningParts()` as a named function, but this logic was refactored into the `cleanMessage()` function (inline filtering within that function). The named export no longer exists. **Suggested Changes**: - Update the reference from `filterOrphanedReasoningParts()` to describe the filtering logic within `cleanMessage()` in `src/ipc/utils/ai_messages_utils.ts` --- #### rules/adding-settings.md **Status**: Keep **Reasoning**: All file paths verified: `UserSettingsSchema` in `src/lib/schemas.ts`, `DEFAULT_SETTINGS` in `src/main/settings.ts`, `SETTING_IDS` in `src/lib/settingsSearchIndex.ts`, `AutoApproveSwitch.tsx` as template. Recent commit d6ab829 (add max tool call steps setting) confirms this pattern is actively used. --- #### rules/chat-message-indicators.md **Status**: Keep **Reasoning**: Short (12 lines), low token cost. `dyad-status` tag implementation confirmed in